-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Target 390]Serialize BufferAsset as CCON #15513
base: develop
Are you sure you want to change the base?
Conversation
607a1a5
to
de47ea6
Compare
cocos/asset/assets/buffer-asset.ts
Outdated
} | ||
|
||
public validate () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the public API validate
?
945b846
to
fbe1e74
Compare
*/ | ||
@override | ||
get _nativeAsset (): ArrayBuffer | ArrayBufferView { | ||
return this._buffer as ArrayBuffer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overridden get/set _nativeAsset
is removed. Will it break the compatibility?
The old get _nativeAsset
return this._buffer
, but now it returns this._file
from its parent class Asset
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the method documented, this is an engine private interface and has been deprecated since v3.5.0 and is explicitly starts with an underscore. We can directly removed it in v3.9.0.
7e39685
to
c2513e8
Compare
c2513e8
to
4f08974
Compare
Re: #
Changelog
BufferAsset
so that it can be serialized as CCON format.Continuous Integration
This pull request:
Compatibility Check
This pull request: