Move CNCF information below hero for takeovers #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Hunt <[email protected]>
|
I like the idea. I'm not sure about the blog image since it can't really compete with the hero above it. What about using a Phippy character in that space? Maybe Phippy himself? |
|
The blob in my thinking connected the homepage to the blobs on other pages (which I never felt it did before) The picture could definitely improve this was the first I found in our library (the blob shape is auto-applied) But happy to look at all options. I felt it needed something on that right side as its a bit empty otherwise. |
|
Let's keep this open for when we do the takeover for Kubecon NA #831 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have previously implemented home page takeovers for events the introduction to CNCF that sits in the hero disappears. This attempts to remedy that by introducing a new section below the hero which can be used whenever new takeovers are used. It reuses existing styles, and any custom styles are encapsulated in the file (home-cncf-about.php).
PR - https://pr-859-cncfci.pantheonsite.io