Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[o11y] Add remaining R2 span tags #3256

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Dec 18, 2024

Please consult the (internal) span definitions to review the added span tags. Input is welcome on API design for r2GetClient() and getHttpClientWithCallback().

@fhanau fhanau requested a review from mikea December 18, 2024 16:12
@fhanau fhanau requested review from a team as code owners December 18, 2024 16:12
@fhanau fhanau requested review from ObsidianMinor and removed request for a team December 18, 2024 16:12
Copy link

github-actions bot commented Dec 18, 2024

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@fhanau fhanau force-pushed the felix/subrequest-client-spans-next branch from 24366c3 to f4b9130 Compare December 18, 2024 16:45
@fhanau fhanau requested a review from a team as a code owner December 18, 2024 16:45
@fhanau fhanau force-pushed the felix/111524-user-tracing-otel-v1 branch from 598986f to 956a297 Compare December 18, 2024 16:51
Base automatically changed from felix/111524-user-tracing-otel-v1 to main December 18, 2024 17:39
@fhanau fhanau force-pushed the felix/subrequest-client-spans-next branch from f4b9130 to a8d937b Compare December 18, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant