Name artifact chart.umd.js, fixes #11455 #11457
Conversation
rollup.config.js
Outdated
| }, | ||
|
|
||
| // UMD build | ||
| // dist/chart.umd.js (old filename, deprecated) |
There was a problem hiding this comment.
Yeah, I wouldn't deprecate this now.
There was a problem hiding this comment.
Undeprecated. Not a big deal, it can always be deprecated later.
| @@ -30,7 +30,7 @@ A number of changes were made to the configuration options passed to the `Chart` | |||
| * Time and timeseries scales use `ticks.stepSize` instead of `time.stepSize`, which has been removed. | |||
| * `maxTickslimit` wont be used for the ticks in `autoSkip` if the determined max ticks is less then the `maxTicksLimit`. | |||
| * `dist/chart.js` has been removed. | |||
| * `dist/chart.min.js` has been renamed to `dist/chart.umd.js`. | |||
| * `dist/chart.min.js` has been renamed to `dist/chart.umd.min.js`. | |||
There was a problem hiding this comment.
Not sure we should edit the migration guide.
Since if you look at the latest docs but use version 4.3 this won't be correct.
We can add a (`dist/chart.umd.min.js` after version 4.5.0).
There was a problem hiding this comment.
If they're upgrading to an older version won't they be seeing that older version's migration guide?
There was a problem hiding this comment.
Yes, if you click the right link.
But even if you go to 4.5.0 this change would still be technically incorrect since we did not rename it from old to that we renamed it to what's already there and this gets added
There was a problem hiding this comment.
There are arguments for both approaches. And I support either.
Here is a PR for the other wording: #11470
There was a problem hiding this comment.
Would be more in favour of that one, but it wont be a dealbreaker for me.
Seems the test in both pr's fail on that it can't load 'src/chart.umd.min.js':
Uncaught NetworkError: Failed to execute 'importScripts' on 'WorkerGlobalScope': The script at 'src/chart.umd.min.js' failed to load. thrown
fulldecent
force-pushed
the
fix-min-js
branch
from
cfb968f to
77c65d0
Compare
This names our already minified UMD dist file to the format that jsDelivr specifies for this type of file.