Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svelte): frame for svelte #3171

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

domuk-k
Copy link
Contributor

@domuk-k domuk-k commented Dec 25, 2024

Why
tried to push forward Svelte 1.0

What
implemented for svelte, referencing others(react,solid)

  • Frame
  • Portal

How
I aimed to create it with an interface consistent with those of other UI libraries
With storybook, consistency in terms of the output/results as well

  • portal implemented without a wrapper via Svelte's mount API

Result
React Frame | Svelte Frame
스크린샷 2024-12-25 오후 9 21 11

image

Copy link

vercel bot commented Dec 25, 2024

@domuk-k is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pkg-pr-new bot commented Dec 25, 2024

Open in Stackblitz

npm i https://pkg.pr.new/chakra-ui/ark/@ark-ui/react@3171
npm i https://pkg.pr.new/chakra-ui/ark/@ark-ui/solid@3171
npm i https://pkg.pr.new/chakra-ui/ark/@ark-ui/vue@3171
npm i https://pkg.pr.new/chakra-ui/ark/@ark-ui/svelte@3171

commit: 8046c42

@segunadebayo segunadebayo merged commit 66804ad into chakra-ui:main Dec 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants