Wait for factored pipelines to drain before ending main pipeline #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade to labeled-stream-splicer@2 in 532b1e4 broke a test, because of some fun times with stream end timings. The factored files were not written fully by the time the common bundle was finished. This patch ensures that all entries are fully written before the main bundle stream completes. This way you can reliably use the `bundle.on('end')` event as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to labeled-stream-splicer@2 in 532b1e4
broke a test, because of some fun times with stream end timings. The
factored files were not written fully by the time the common bundle was
finished. This patch ensures that all entries are fully written before
the main bundle stream completes. This way you can reliably use the
bundle.on('end')event as well.