Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): SageMakerCreateTrainingJob add sagemaker:AddTags permission #32536

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

phuhung273
Copy link
Contributor

@phuhung273 phuhung273 commented Dec 16, 2024

Issue # (if applicable)

Closes #32294

Reason for this change

  • Missing permission
Screenshot 2024-12-15 171605

Description of changes

  • StepFunctions add sagemaker:AddTags permission

Description of how you validated changes

Unit + Integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Dec 16, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 16, 2024 11:16
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 16, 2024
@phuhung273 phuhung273 changed the title Stepfunction createtrainingjob addtag permission fix(stepfunctions-tasks): CreateTrainingJob add sagemaker:AddTag permission Dec 16, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@phuhung273 phuhung273 changed the title fix(stepfunctions-tasks): CreateTrainingJob add sagemaker:AddTag permission fix(stepfunctions-tasks): SageMakerCreateTrainingJob add sagemaker:AddTag permission Dec 16, 2024
@phuhung273 phuhung273 changed the title fix(stepfunctions-tasks): SageMakerCreateTrainingJob add sagemaker:AddTag permission fix(stepfunctions-tasks): SageMakerCreateTrainingJob add sagemaker:AddTags permission Dec 16, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 16, 2024 11:20

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (bf026bd) to head (4e2d47a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32536   +/-   ##
=======================================
  Coverage   78.77%   78.77%           
=======================================
  Files         108      108           
  Lines        7163     7163           
  Branches     1320     1320           
=======================================
  Hits         5643     5643           
  Misses       1335     1335           
  Partials      185      185           
Flag Coverage Δ
suite.unit 78.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.77% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 16, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4e2d47a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
2 participants