[SPARK-50667][PYTHON][TESTS] Make jinja2 optional in PySpark Tests
#49288
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
changed the title
jinja2 optional in PySpark Tests
zhengruifeng
requested review from
HyukjinKwon,
xinrong-meng and
dongjoon-hyun
HyukjinKwon
reviewed
Dec 26, 2024
python/pyspark/pandas/frame.py
Outdated
| import pyspark.pandas.frame | ||
|
|
||
| os.chdir(os.environ["SPARK_HOME"]) | ||
|
|
||
| globs = pyspark.pandas.frame.__dict__.copy() | ||
| if not have_jinja2: | ||
| del pyspark.pandas.frame.DataFrame.to_latex.__doc__ |
There was a problem hiding this comment.
I think we usually just skip doctests (and rely on unittests) in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
jinja2optional in PySpark TestsWhy are the changes needed?
jinja2is an optional dependency ofpandashttps://pypi.org/pypi/pandas/2.2.0/json
It is not a mandatory requirement of pyspark, so PySpark tests should succeed even it is not installed
Does this PR introduce any user-facing change?
no, test-only
How was this patch tested?
manually test after uninstalling it
Was this patch authored or co-authored using generative AI tooling?
no