Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-912: Rule based sentence detector #390

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package opennlp.tools.sentdetect.segment;

public class Clean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be a Record ?


String regex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth to use a Pattern here to avoid compiling the regex in every replaceAll(...) call.

String replacement;

/**
* @param regex the regular expression to which this string is to be matched
* @param replacement the string to be substituted for each match
*/
public Clean(String regex, String replacement) {
this.regex = regex;
this.replacement = replacement;
}

public String getRegex() {
return regex;
}

public String getReplacement() {
return replacement;
}

@Override
public String toString() {
return "Clean{" +
"regex='" + regex + '\'' +
", replacement='" + replacement + '\'' +
'}';
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package opennlp.tools.sentdetect.segment;

import java.util.ArrayList;
import java.util.List;

/**
* removes errant newlines, xhtml, inline formatting, etc.
*/
public class Cleaner {

public List<Clean> cleanList = new ArrayList<Clean>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this public ?


public String clean(String text) {
for (Clean clean : cleanList) {
text = text.replaceAll(clean.getRegex(), clean.getReplacement());
}
return text;
}

public void clear() {
if (cleanList != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list is never null

cleanList.clear();
}
}

/**
* TODO: Move rules into profiles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still valid? What is meant by this TODO?

*/
public void rules() {

cleanList.add(new Clean("\\n(?=[a-zA-Z]{1,2}\\n)", ""));

cleanList.add(new Clean("\\n \\n", "\n"));

cleanList.add(new Clean("\\n\\n", "\n"));

cleanList.add(new Clean("\\n(?=\\.(\\s|\\n))", ""));
cleanList.add(new Clean("(?<=\\s)\\n", ""));
cleanList.add(new Clean("(?<=\\S)\\n(?=\\S)", " \n "));
cleanList.add(new Clean("\\n", "\n"));
cleanList.add(new Clean("\\\\n", "\n"));
cleanList.add(new Clean("\\\\\\ n", "\n"));

cleanList.add(new Clean("\\{b\\^&gt;\\d*&lt;b\\^\\}|\\{b\\^>\\d*<b\\^\\}",""));

cleanList.add(new Clean("\\.{4,}\\s*\\d+-*\\d*","\r"));

// cleanList.add(new Clean("\\.{5,}", " "));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove outcommented lines?

cleanList.add(new Clean("\\/{3}", ""));

// cleanList.add(new Clean("(?<=[a-z])\\.(?=[A-Z])", ". "));
// cleanList.add(new Clean("(?<=\\d)\\.(?=[A-Z])", ". "));

cleanList.add(new Clean("\\n(?=•')", "\r"));
cleanList.add(new Clean("''", "\""));
cleanList.add(new Clean("``", "\""));

}

public void html() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can replace this pattern with a builder pattern (instead of profiles), so one can do something like:

new Cleaner.Builder().withDefaults().withHTML().withPDF().build()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we should also allow, that a user can just add custom rules:

new Cleaner.Builder().withDefaults().withHTML().withPDF().withCustomRules(rules).build()

cleanList.add(new Clean("<\\/?\\w+((\\s+\\w+(\\s*=\\s*(?:\\\".*?\\\"|'.*?'|" +
"[\\^'\\\">\\s]+))?)+\\s*|\\s*)\\/?>", ""));
cleanList.add(new Clean("&lt;\\/?[^gt;]*gt;", ""));
}

public void pdf() {
cleanList.add(new Clean("(?<=[^\\n]\\s)\\n(?=\\S)", ""));
cleanList.add(new Clean("\\n(?=[a-z])", " "));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package opennlp.tools.sentdetect.segment;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

/**
* Represents rule for segmenting text in some language. Contains {@link Rule}
* list.
*
*/
public class LanguageRule {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Record?


private List<Rule> ruleList;

private String name;

/**
* Creates language rule.
*
* @param name language rule name
* @param ruleList rule list (it will be shallow copied)
*/
public LanguageRule(String name, List<Rule> ruleList) {
this.ruleList = new ArrayList<Rule>(ruleList);
this.name = name;
}

/**
* Creates empty language rule.
*
* @param name language rule name
*/
public LanguageRule(String name) {
this(name, new ArrayList<Rule>());
}

/**
* @return unmodifiable rules list
*/
public List<Rule> getRuleList() {
return Collections.unmodifiableList(ruleList);
}

/**
* Adds rule to the end of rule list.
* @param rule
*/
public void addRule(Rule rule) {
ruleList.add(rule);
}

/**
* @return language rule name
*/
public String getName() {
return name;
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,145 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package opennlp.tools.sentdetect.segment;

import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.regex.Pattern;

public class LanguageTool {

private LanguageRule languageRule;

private String languageName;

private Map<String, Object> cache;

public static final String MAX_LOOKBEHIND_LENGTH_PARAM = "maxLookbehindLength";

public static final int DEFAULT_MAX_LOOKBEHIND_LENGTH = 100;

private int maxLookbehindLength;

private Map<String, Object> parameterMap;

private List<Rule> breakRuleList;

private Pattern noBreakPattern;

public LanguageTool(String languageName, LanguageRule languageRule) {
this(languageName, languageRule, Collections.emptyMap());
}

public LanguageTool(String languageName, LanguageRule languageRule, Map<String, Object> paramMap) {
this.languageRule = languageRule;
this.languageName = languageName;
parameterMap = new HashMap<String, Object>(paramMap);
if (parameterMap.get(MAX_LOOKBEHIND_LENGTH_PARAM) != null) {
this.maxLookbehindLength = (int) parameterMap.get(MAX_LOOKBEHIND_LENGTH_PARAM);
} else {
this.maxLookbehindLength = DEFAULT_MAX_LOOKBEHIND_LENGTH;
}
init();
}

private void init() {

this.cache = new ConcurrentHashMap<String, Object>();
this.breakRuleList = new ArrayList<Rule>();
StringBuilder noBreakPatternBuilder = new StringBuilder();

for (Rule rule : languageRule.getRuleList()) {

if (rule.isBreak()) {
breakRuleList.add(rule);
} else {
if (noBreakPatternBuilder.length() > 0) {
noBreakPatternBuilder.append('|');
}
String patternString = createNoBreakPatternString(rule);
noBreakPatternBuilder.append(patternString);
}
}

if (noBreakPatternBuilder.length() > 0) {
String noBreakPatternString = noBreakPatternBuilder.toString();
noBreakPattern = compile(noBreakPatternString);
} else {
noBreakPattern = null;
}

}

public Map<String, Object> getParameterMap() {
return parameterMap;
}

public LanguageRule getLanguageRule() {
return languageRule;
}

public String getLanguageName() {
return languageName;
}

public Map<String, Object> getCache() {
return cache;
}

public Pattern compile(String regex) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to simplify by using computeIfAbsent.

String key = "PATTERN_" + regex;
Pattern pattern = (Pattern) getCache().get(key);
if (pattern == null) {
pattern = Pattern.compile(regex);
getCache().put(key, pattern);
}
return pattern;
}

public List<Rule> getBreakRuleList() {
return breakRuleList;
}

public Pattern getNoBreakPattern() {
return noBreakPattern;
}

private String createNoBreakPatternString(Rule rule) {

StringBuilder patternBuilder = new StringBuilder();

// As Java does not allow infinite length patterns
// in lookbehind, before pattern need to be shortened.
String beforePattern = RuleUtil.finitize(rule.getBeforePattern(), maxLookbehindLength);
String afterPattern = rule.getAfterPattern();

patternBuilder.append("(?:");
if (beforePattern.length() > 0) {
patternBuilder.append(beforePattern);
}
if (afterPattern.length() > 0) {
patternBuilder.append(afterPattern);
}
patternBuilder.append(")");
return patternBuilder.toString();
}
}
Loading