OPFS support for OpenDAL (draft PR) #5269
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Nov 5, 2024
| @@ -381,6 +381,20 @@ prometheus-client = { version = "0.22.2", optional = true } | |||
| tracing = { version = "0.1", optional = true } | |||
| # for layers-dtrace | |||
| probe = { version = "0.5.1", optional = true } | |||
| wasm-bindgen = "0.2.95" | |||
There was a problem hiding this comment.
Hi, please mark those dependencies as optional and hide them under the services-opfs feature to ensure other builds aren't affected.
| access_info | ||
| .set_scheme(Scheme::Opfs) | ||
| .set_native_capability(Capability { | ||
| stat: true, |
There was a problem hiding this comment.
Please leave them as false until we actually implement them.
| Arc::new(access_info) | ||
| } | ||
|
|
||
| async fn create_dir(&self, path: &str, _: OpCreateDir) -> Result<RpCreateDir> { |
There was a problem hiding this comment.
We have default implementations for those functions, so we can remove unsupported operations.
| impl OpfsCore { | ||
| pub async fn store_file(file_name: &str, content: &[u8]) -> Result<(), JsValue> { | ||
| // Access the OPFS | ||
| let navigator = window().unwrap().navigator(); |
There was a problem hiding this comment.
Please try your best to avoid using unwrap(), and return an error instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2442 .
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?