Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: fix TopicCommand warning message.format.version output #18311

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

FrankYang0529
Copy link
Member

Before:

> ./bin/kafka-topics.sh --create --topic my-topic --bootstrap-server localhost:9092 --config message.format.version=0.10.2-IV0
WARNING: The configuration ${TopicConfig.MESSAGE_FORMAT_VERSION_CONFIG}=${props.getProperty(TopicConfig.MESSAGE_FORMAT_VERSION_CONFIG)} is specified. This configuration will be ignored if the version is newer than the inter.broker.protocol.version specified in the broker or if the inter.broker.protocol.version is 3.0 or newer. This configuration is deprecated and it will be removed in Apache Kafka 4.0.
Created topic my-topic.

After:

> ./bin/kafka-topics.sh --create --topic my-topic --bootstrap-server localhost:9092 --config message.format.version=0.10.2-IV0
WARNING: The configuration message.format.version=0.10.2-IV0 is specified. This configuration will be ignored if the version is newer than the inter.broker.protocol.version specified in the broker or if the inter.broker.protocol.version is 3.0 or newer. This configuration is deprecated and it will be removed in Apache Kafka 4.0.
Created topic my-topic.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was a regression from the conversion of Scala to Java. The change LGTM to me. Are there any branches affected besides 3.9?

@FrankYang0529
Copy link
Member Author

Are there any branches affected besides 3.9?

Yes, both 3.7 and 3.8 also have same issue. I think we can merge this and use backport to fix other branches. Or do I need to create another two PRs for them? Thanks.

@chia7712
Copy link
Member

the failed tests pass on my local, and I think they are unrelated to this PR

@chia7712 chia7712 merged commit f5952c6 into apache:3.9 Dec 25, 2024
1 check failed
chia7712 pushed a commit that referenced this pull request Dec 25, 2024
@chia7712
Copy link
Member

I have backported this PR to the 3.8 branch only (commit ab5490147537d9d4a581a6fde44dc43a27d6eb7c) since I believe we will not be releasing any further versions of the 3.7 branch

@FrankYang0529 FrankYang0529 deleted the minor-fix-topiccommand-output branch December 25, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants