KAFKA-18274: Failed to restart controller in testing due to closed socket channel [1/2]

[peterxcli]

We should rebuild the metrics of SharedServer when restart the controller in test to prevent NPE.

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[chia7712]

Should we do similar fix to BrokerServer? It uses the metrics as well.

[peterxcli]

Hi, @chia7712 Thanks for your review.

Regarding the BrokerServer, it calls sharedServer.startForBroker() at the beginning of the startup method, which also checks if the metrics are null

However, we cannot apply the same approach to the ControllerServer because sharedServer.startForController() in it depends on listenerInfo. Therefore, this change is necessary.

Here is the relevant reference:

• BrokerServer startup method
• listenerInfo dependence in ControllerServer

[peterxcli]

Unrelated tests failed🥲:

Java23:

SaslSslAdminIntegrationTest	"testCreateTopicsResponseMetadataAndConfig(String).quorum=kraft"	org.opentest4j.AssertionFailedError: Expected java.util.concurrent.ExecutionException to be thrown, but nothing was thrown.	7.02s
PlaintextAdminIntegrationTest	testConsumerGroupsDeprecatedConsumerGroupState(String, String).quorum=kraft.groupProtocol=consumer	org.opentest4j.AssertionFailedError: Expected the offset for partition 0 to eventually become 1.	21.58s
PlaintextAdminIntegrationTest	testConsumerGroups(String, String).quorum=kraft.groupProtocol=consumer	org.opentest4j.AssertionFailedError: Expected the offset for partition 0 to eventually become 1.	22.18s

Java17:

AbstractCoordinatorTest	testWakeupAfterSyncGroupReceivedExternalCompletion()	org.opentest4j.AssertionFailedError: Should have woken up from ensureActiveGroup() ==> Expected org.apache.kafka.common.errors.WakeupException to be thrown, but nothing was thrown.	0.48s