KAFKA-17607: Add CI step to verify LICENSE-binary #18299
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
mumrah
reviewed
Dec 23, 2024
.github/workflows/build.yml
Outdated
| @@ -143,6 +143,9 @@ jobs: | |||
| find ./site-docs/generated -type f -exec grep -L "." {} \; >&2 | |||
| exit 1 | |||
| fi | |||
| - name: Check missing lib license | |||
| run: | | |||
| ./gradlew libLicenseCheck | |||
There was a problem hiding this comment.
Can you add this to the previous gradlew invocation?
build.gradle
Outdated
| @@ -1328,6 +1328,43 @@ project(':core') { | |||
| duplicatesStrategy 'exclude' | |||
| } | |||
|
|
|||
| task libLicenseCheck(dependsOn: 'releaseTarGz', type: Copy) { | |||
There was a problem hiding this comment.
I think it would be better to do this as part of releaseTarGz so we can't mistakenly produce an artifact that is missing licenses. I glanced through build.gradle and I don't see where we're gathering the libraries into the LICENSE file. Do you know where that happens?
m1a2st
reviewed
Dec 25, 2024
Comment on lines
+146
to
+148
| - name: Check missing lib license | ||
| run: | | ||
| ./gradlew releaseTarGz |
There was a problem hiding this comment.
I think @mumrah means, this gradle command should move to Compile and validate step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Committer Checklist (excluded from commit message)