KAFKA-18339: Remove raw unversioned direct SASL protocol (KIP-896) #18295
+64
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijuma
commented
Dec 24, 2024
| // Raise an error prior to parsing if the api cannot be handled at this layer. This avoids | ||
| // unnecessary exposure to some of the more complex schema types. | ||
| if (apiKey != ApiKeys.API_VERSIONS && apiKey != ApiKeys.SASL_HANDSHAKE) | ||
| throw new IllegalSaslStateException("Unexpected Kafka request of type " + apiKey + " during SASL handshake."); | ||
| throw new InvalidRequestException("Unexpected Kafka request of type " + apiKey + " during SASL handshake."); |
There was a problem hiding this comment.
@rajinisivaram Do you know why we send IllegalSaslStateException here and InvalidRequestException for every other error? We seem to have special handling for Sasl related exceptions, but it doesn't seem to make sense in this case since we can't properly propagate an error if we get the wrong request type.
ijuma
commented
Dec 24, 2024
| // InvalidRequestException is thrown if the request is not in Kafka format or if the API key is invalid. | ||
| // If it's the initial request, this could be an ancient client (see method documentation for more details), | ||
| // a client configured with the wrong security protocol or a non kafka-client altogether (eg http client). | ||
| throw new InvalidRequestException("Invalid request, potential reasons: kafka client configured with the " + |
There was a problem hiding this comment.
Please take a look at the error message and check if it makes sense. This will only be captured in the broker, but still good to try and make it as informative as possible.
ijuma
force-pushed
the
kafka-18339-remove-raw-unversioned-sasl
branch
from
061cbb0 to
12d120c
Compare
|
@rajinisivaram @omkreddy Any of you has cycles to review this small change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients that support SASL but don't implement KIP-43 (eg Kafka producer/consumer 0.9.0.x) will
fail to connect after this change.
Added unit tests and also manually tested with the console producer 0.9.0.
While testing, I noticed that the logged message when a 0.9.0 Java client is used without sasl is
slightly misleading - fixed that too.
Committer Checklist (excluded from commit message)