IGNITE-23305 Get rid of client HybridTimestampTracker #4929
+659
−521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vldpyatkov
force-pushed
the
ignite-23305
branch
from
3123be1 to
d60b660
Compare
xtern
reviewed
Dec 23, 2024
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
Show resolved
Hide resolved
...ient-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java
Show resolved
Hide resolved
xtern
reviewed
Dec 23, 2024
...ient-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java
Show resolved
Hide resolved
korlov42
reviewed
Dec 23, 2024
...sactions/src/main/java/org/apache/ignite/internal/tx/impl/IgniteAbstractTransactionImpl.java
Outdated
Show resolved
Hide resolved
...es/transactions/src/main/java/org/apache/ignite/internal/tx/ObservableTimestampProvider.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlCursorCloseRequest.java
Outdated
Show resolved
Hide resolved
...client-handler/src/main/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImpl.java
Outdated
Show resolved
Hide resolved
korlov42
approved these changes
Dec 24, 2024
| @@ -35,14 +35,14 @@ | |||
| public class IgniteTransactionsImpl implements IgniteTransactions { | |||
| private final TxManager txManager; | |||
|
|
|||
| private final HybridTimestampTracker observableTimestampTracker; | |||
| private final HybridTimestampTrackerImpl observableTimestampTracker; | |||
There was a problem hiding this comment.
let's use interface instead of implementation. Besides, there are number of methods which are not used anymore. Let's clean up IgniteTransactionsImpl
There was a problem hiding this comment.
In this instance, the field can only be an instance of HybridTimestampTrackerImpl.
It is not worth overdoing with the use of interfaces.
There was a problem hiding this comment.
there are number of methods which are not used anymore
Good point.
| @@ -362,7 +362,7 @@ public class TableManager implements IgniteTablesInternal, IgniteComponent { | |||
|
|
|||
| private final LowWatermark lowWatermark; | |||
|
|
|||
| private final HybridTimestampTracker observableTimestampTracker; | |||
| private final HybridTimestampTrackerImpl observableTimestampTracker; | |||
There was a problem hiding this comment.
let's use interface here and below. Please check this kind of changes everywhere in your patch
There was a problem hiding this comment.
I prefer to use a concrete implementation until the other is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23305