IGNITE-23927 ItDataSchemaSyncTest.checkSchemasCorrectlyRestore is flaky #4911
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vldpyatkov
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: IGNITE-23927
The goal
The main goal of the PR is to fix and enable back
ItDataSchemaSyncTest.checkSchemasCorrectlyRestoretest.The reason
Tests are should be enabled and working.
The solution
The issue was in replication timeout equals 3s for all tests in the class, but it leads to
ReplicationTimeoutException. The last is desired for thetestExpectReplicationTimeoutonly, but due to default zone usage other tests may struggle over massive rebalances that leads to delays on message handling e.g. metastore events. ThecheckSchemasCorrectlyRestorehad sometimes a little more that 3s time for a pratition to became a primary that leads to the corresponding exception. Normally there is 1min timeout.The solution is to remove per-class timeout property and to set 3s timeout only for
testExpectReplicationTimeoutwith cluster configuration change. Thus this test will thrown the expected exception because the 3s timeout and all other tests will be fine with 1min timeout.