[BP-1.20][FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities #25830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulnerabilities (apache#25718) Follow up of https://issues.apache.org/jira/browse/FLINK-36739 Contribute-to: https://issues.apache.org/jira/browse/FLINK-36740
davidradl
reviewed
Dec 20, 2024
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| ################################################################################ | ||
| if ! npm list -g @wbmnky/license-report-generator > /dev/null |
There was a problem hiding this comment.
I suggest a comment detailing what the shell script does, why is would be useful and when to run it.
davidradl
reviewed
Dec 20, 2024
| @@ -108,6 +108,13 @@ re-compilation: | |||
| $ npm run lint | |||
| ``` | |||
|
|
|||
| ### How to update the NOTICE | |||
| > Tip: If you've made a modification to any of the dependencies, make sure you've run `dev/generate_notice` before committing to update the `NOTICE` file. | |||
There was a problem hiding this comment.
we should say npm dependancies I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR backport the changes done of the PR made by me in (#25718) in master for version 1.20.X to be used in dependencies upgrade and vulnerabilities fixes.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation