[FLINK-36842] FlinkPipelineComposer allows injecting StreamExecutionEnvironment #3775
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharonx
reviewed
Dec 15, 2024
| public static FlinkPipelineComposer ofStreamExecutionEnvironment( | ||
| StreamExecutionEnvironment env) { | ||
| return new FlinkPipelineComposer(env, false); | ||
| } |
There was a problem hiding this comment.
hmm to me this essentially expose the constructor and it's a bit opaque to set isBlocking=false statically here as you can have blocking mode for stream execution env too. My proposal is to make the constructor below public.
private FlinkPipelineComposer(StreamExecutionEnvironment env, boolean isBlocking) {
this.env = env;
this.isBlocking = isBlocking;
}
@PatrickRen I see that you are tagged in the history of the class. Any opinions?
|
|
||
| public ExecutionInfo(String id, String description) { | ||
| this.id = id; | ||
| this.description = description; | ||
| this.jobClient = null; |
There was a problem hiding this comment.
I'd try to avoid null usage as much as possible to avoid potential NPEs. It does look like the jobClient is available in all the places that construct ExecutionInfo. So can we just change the constructor? If not, please add @Nullable wherever is applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user of the FlinkPipelineComposer API, I would like to run jobs with a pre-configured StreamExecutionEnvironment of my choosing, for commonality with executing non-Flink-CDC jobs. However, the API only allows me to pass a Configuration object, which FlinkPipelineComposer uses to build its own StreamExecutionEnvironment.
In addition, I would like to retrieve a JobClient from submitted jobs, again for commonality with non-Flink-CDC jobs.