Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](olap) Set the original tablet state to TABLET_SHUTDOWN #45812 #45891

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45812

Set the original tablet state to TABLET_SHUTDOWN when loading a new
tablet from the disk during the restore job. Otherwise, the other thread
may hold the old tablet object, and save meta too.
@Thearas
Copy link
Contributor

Thearas commented Dec 25, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 25, 2024
@Thearas
Copy link
Contributor

Thearas commented Dec 25, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40355 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d05e66eb4b0fba833a3357622a68809ef014ce5d, data reload: false

------ Round 1 ----------------------------------
q1	17577	7326	7303	7303
q2	2059	165	169	165
q3	10927	1071	1127	1071
q4	10537	680	701	680
q5	7704	2784	2848	2784
q6	233	144	148	144
q7	975	617	605	605
q8	9716	1941	1997	1941
q9	8379	6451	6444	6444
q10	7032	2265	2289	2265
q11	495	269	264	264
q12	398	213	207	207
q13	17774	2977	3001	2977
q14	229	210	207	207
q15	548	503	525	503
q16	709	593	617	593
q17	961	516	581	516
q18	7190	6469	6534	6469
q19	1365	1039	1060	1039
q20	458	202	200	200
q21	4186	2993	3075	2993
q22	1048	985	987	985
Total cold run time: 110500 ms
Total hot run time: 40355 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7274	7232	7195	7195
q2	321	251	236	236
q3	2934	2894	2868	2868
q4	2036	1822	1757	1757
q5	5634	5656	5690	5656
q6	225	142	142	142
q7	2134	1748	1747	1747
q8	3302	3571	3438	3438
q9	8714	8931	8832	8832
q10	3527	3506	3465	3465
q11	616	497	491	491
q12	778	594	598	594
q13	16473	3122	3155	3122
q14	303	270	273	270
q15	571	527	502	502
q16	695	678	666	666
q17	1838	1619	1602	1602
q18	8244	7794	7565	7565
q19	6169	1571	1546	1546
q20	2061	1862	1851	1851
q21	5403	5215	5290	5215
q22	1131	977	988	977
Total cold run time: 80383 ms
Total hot run time: 59737 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195668 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d05e66eb4b0fba833a3357622a68809ef014ce5d, data reload: false

query1	1330	910	905	905
query2	6265	2007	2005	2005
query3	10874	4196	4163	4163
query4	66158	29563	23588	23588
query5	5218	455	477	455
query6	452	175	175	175
query7	5660	315	330	315
query8	313	243	233	233
query9	9446	2756	2754	2754
query10	502	279	255	255
query11	17724	15271	15683	15271
query12	169	105	102	102
query13	1579	435	450	435
query14	10591	6648	7489	6648
query15	222	191	185	185
query16	7335	522	528	522
query17	1054	557	564	557
query18	2010	319	327	319
query19	220	164	159	159
query20	119	112	110	110
query21	66	46	46	46
query22	4761	4678	4433	4433
query23	34459	34251	34122	34122
query24	6221	2914	2926	2914
query25	536	423	412	412
query26	699	170	168	168
query27	1895	294	313	294
query28	4131	2539	2528	2528
query29	714	460	456	456
query30	247	171	169	169
query31	998	847	839	839
query32	66	58	59	58
query33	483	282	293	282
query34	893	515	510	510
query35	849	745	756	745
query36	1105	975	957	957
query37	126	76	80	76
query38	4101	3971	4054	3971
query39	1525	1458	1470	1458
query40	144	83	88	83
query41	75	46	46	46
query42	107	95	96	95
query43	516	495	498	495
query44	1194	817	800	800
query45	188	175	167	167
query46	1124	738	718	718
query47	1988	1888	1866	1866
query48	466	362	363	362
query49	708	381	386	381
query50	833	423	413	413
query51	7462	7107	7183	7107
query52	104	92	86	86
query53	266	180	192	180
query54	551	443	439	439
query55	77	74	77	74
query56	247	238	229	229
query57	1155	1104	1055	1055
query58	205	202	204	202
query59	3221	2938	2814	2814
query60	277	265	240	240
query61	110	105	104	104
query62	770	651	674	651
query63	208	195	202	195
query64	1620	650	618	618
query65	3217	3190	3163	3163
query66	717	306	338	306
query67	15795	15232	15286	15232
query68	5040	553	568	553
query69	453	256	258	256
query70	1194	1080	1128	1080
query71	470	263	256	256
query72	6730	3928	3892	3892
query73	764	346	347	346
query74	10257	8872	8964	8872
query75	3307	2621	2567	2567
query76	2700	993	1102	993
query77	496	275	280	275
query78	10703	9697	9504	9504
query79	8177	599	589	589
query80	2091	431	417	417
query81	555	244	239	239
query82	1759	122	118	118
query83	261	142	140	140
query84	286	90	83	83
query85	1273	308	294	294
query86	496	312	266	266
query87	4357	4185	4452	4185
query88	5156	2387	2380	2380
query89	537	287	292	287
query90	2137	190	187	187
query91	174	143	146	143
query92	73	49	51	49
query93	6416	537	540	537
query94	852	289	291	289
query95	368	250	255	250
query96	630	279	275	275
query97	3348	3144	3174	3144
query98	217	204	198	198
query99	1613	1293	1289	1289
Total cold run time: 337351 ms
Total hot run time: 195668 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.57 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d05e66eb4b0fba833a3357622a68809ef014ce5d, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.63	0.11	0.11
query5	0.51	0.51	0.50
query6	1.13	0.72	0.72
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.50	0.49
query10	0.56	0.53	0.54
query11	0.13	0.10	0.10
query12	0.14	0.13	0.11
query13	0.59	0.59	0.59
query14	3.03	2.96	2.93
query15	0.89	0.82	0.82
query16	0.37	0.39	0.38
query17	1.02	1.00	1.04
query18	0.24	0.22	0.21
query19	1.93	1.80	2.01
query20	0.02	0.01	0.01
query21	15.38	0.62	0.57
query22	2.42	1.89	2.28
query23	16.86	0.86	1.01
query24	3.07	0.72	0.76
query25	0.24	0.05	0.11
query26	0.46	0.13	0.13
query27	0.05	0.05	0.04
query28	11.26	1.10	1.07
query29	12.57	3.24	3.25
query30	0.25	0.06	0.07
query31	2.84	0.38	0.38
query32	3.26	0.47	0.47
query33	2.93	2.98	2.99
query34	17.03	4.40	4.41
query35	4.56	4.47	4.46
query36	0.68	0.51	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.03	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.51 s
Total hot run time: 32.57 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants