Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[env](compile) open compile check in lru_cache #45880

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Dec 24, 2024

What problem does this PR solve?

open compile check in lru_cache

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 24, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xinyiZzz
Copy link
Contributor Author

run buildall

@xinyiZzz
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32852 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4de90095424b7332aa9abe650f891d3114501625, data reload: false

------ Round 1 ----------------------------------
q1	17589	6268	6023	6023
q2	2049	292	165	165
q3	10440	1371	735	735
q4	10212	904	449	449
q5	7535	2221	1979	1979
q6	201	181	154	154
q7	899	755	622	622
q8	9252	1387	1201	1201
q9	5308	5026	4985	4985
q10	6784	2323	1852	1852
q11	467	281	261	261
q12	358	361	217	217
q13	17762	3603	3030	3030
q14	237	236	206	206
q15	586	531	518	518
q16	620	616	608	608
q17	569	861	332	332
q18	7290	6404	6486	6404
q19	1722	980	572	572
q20	321	339	194	194
q21	3078	2235	2040	2040
q22	359	334	305	305
Total cold run time: 103638 ms
Total hot run time: 32852 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6298	6226	6642	6226
q2	235	343	235	235
q3	2287	2697	2363	2363
q4	1436	1855	1435	1435
q5	4371	4778	4985	4778
q6	186	177	139	139
q7	2085	2008	1837	1837
q8	2623	2782	2668	2668
q9	7453	7286	7324	7286
q10	3092	3347	2851	2851
q11	585	526	507	507
q12	688	780	632	632
q13	3422	3772	3157	3157
q14	317	312	291	291
q15	559	513	522	513
q16	650	675	666	666
q17	1220	1746	1263	1263
q18	7818	7433	7025	7025
q19	793	1076	1091	1076
q20	1928	1964	1820	1820
q21	5550	5185	4913	4913
q22	610	592	558	558
Total cold run time: 54206 ms
Total hot run time: 52239 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190885 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4de90095424b7332aa9abe650f891d3114501625, data reload: false

query1	967	391	370	370
query2	6537	2365	2346	2346
query3	6713	224	208	208
query4	33887	23695	23609	23609
query5	4331	611	464	464
query6	277	206	170	170
query7	4633	489	295	295
query8	294	249	242	242
query9	9515	2769	2743	2743
query10	473	314	255	255
query11	17961	15374	15232	15232
query12	171	106	104	104
query13	1696	518	398	398
query14	9854	6858	7449	6858
query15	252	200	183	183
query16	8287	618	432	432
query17	1556	737	565	565
query18	2139	416	290	290
query19	202	167	150	150
query20	118	111	111	111
query21	207	123	102	102
query22	4166	4465	4371	4371
query23	34524	33768	33484	33484
query24	6489	2315	2259	2259
query25	488	448	375	375
query26	1192	271	159	159
query27	2074	465	321	321
query28	5218	2454	2450	2450
query29	755	529	414	414
query30	226	182	147	147
query31	994	875	832	832
query32	101	62	61	61
query33	514	357	293	293
query34	776	821	519	519
query35	801	816	730	730
query36	999	1031	972	972
query37	113	100	83	83
query38	4343	4136	4197	4136
query39	1504	1462	1455	1455
query40	212	120	105	105
query41	51	49	48	48
query42	121	104	105	104
query43	528	548	497	497
query44	1294	809	827	809
query45	187	179	176	176
query46	857	1053	663	663
query47	1911	1938	1864	1864
query48	405	430	330	330
query49	796	507	447	447
query50	612	653	390	390
query51	7055	7198	7114	7114
query52	102	103	92	92
query53	231	253	182	182
query54	480	495	406	406
query55	85	78	82	78
query56	262	261	242	242
query57	1226	1172	1138	1138
query58	243	228	229	228
query59	2977	3063	3024	3024
query60	270	263	257	257
query61	133	108	107	107
query62	862	801	749	749
query63	227	192	230	192
query64	4616	988	628	628
query65	3288	3212	3251	3212
query66	1072	422	316	316
query67	16019	16123	15584	15584
query68	9250	753	525	525
query69	456	282	248	248
query70	1231	1145	1106	1106
query71	437	296	259	259
query72	5874	3903	3836	3836
query73	667	759	366	366
query74	10006	9271	8830	8830
query75	4634	3189	2666	2666
query76	4500	1208	811	811
query77	835	370	272	272
query78	10110	10138	9609	9609
query79	3484	895	587	587
query80	696	526	440	440
query81	468	262	233	233
query82	591	148	121	121
query83	196	172	149	149
query84	285	96	74	74
query85	779	371	309	309
query86	359	365	296	296
query87	4628	4632	4435	4435
query88	4523	2242	2226	2226
query89	412	338	307	307
query90	1923	196	192	192
query91	127	141	105	105
query92	66	57	54	54
query93	1062	874	529	529
query94	666	406	258	258
query95	343	266	251	251
query96	482	603	282	282
query97	2754	2873	2685	2685
query98	227	206	200	200
query99	1736	1576	1454	1454
Total cold run time: 295276 ms
Total hot run time: 190885 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4de90095424b7332aa9abe650f891d3114501625, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.03
query3	0.24	0.08	0.06
query4	1.60	0.10	0.11
query5	0.41	0.41	0.40
query6	1.13	0.66	0.66
query7	0.02	0.02	0.01
query8	0.04	0.02	0.04
query9	0.58	0.51	0.51
query10	0.55	0.58	0.56
query11	0.14	0.10	0.10
query12	0.13	0.10	0.12
query13	0.60	0.60	0.60
query14	2.81	2.76	2.74
query15	0.90	0.81	0.83
query16	0.40	0.36	0.37
query17	1.06	1.06	1.03
query18	0.23	0.20	0.21
query19	2.00	1.86	2.01
query20	0.01	0.02	0.01
query21	15.37	0.94	0.59
query22	0.75	0.82	0.92
query23	15.00	1.49	0.51
query24	2.94	1.18	1.40
query25	0.26	0.23	0.13
query26	0.30	0.16	0.14
query27	0.05	0.05	0.04
query28	13.22	1.52	1.04
query29	12.62	3.99	3.30
query30	0.24	0.09	0.06
query31	2.83	0.61	0.38
query32	3.23	0.55	0.46
query33	3.08	3.14	3.10
query34	16.92	5.14	4.52
query35	4.56	4.55	4.52
query36	0.65	0.48	0.49
query37	0.10	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.14	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.49 s
Total hot run time: 31.77 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.80% (10094/26015)
Line Coverage: 29.79% (85182/285902)
Region Coverage: 28.92% (43501/150428)
Branch Coverage: 25.45% (22177/87138)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4de90095424b7332aa9abe650f891d3114501625_4de90095424b7332aa9abe650f891d3114501625/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 25, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz xinyiZzz merged commit dfef170 into apache:master Dec 25, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. not-merge/2.1 not-merge/3.0 reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants