[CELEBORN-1743] [FOLLOWUP]Introduces a configuration option to determine whether application metrics should be included #2964
+134
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaynt4606
changed the title
zaynt4606
commented
Dec 4, 2024
common/src/main/scala/org/apache/celeborn/common/metrics/source/AbstractSource.scala
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
==========================================
- Coverage 32.99% 32.89% -0.09%
==========================================
Files 330 331 +1
Lines 19683 19837 +154
Branches 1766 1781 +15
==========================================
+ Hits 6492 6524 +32
- Misses 12830 12951 +121
- Partials 361 362 +1 ☔ View full report in Codecov by Sentry. |
zaynt4606
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
On the basis of CELEBORN-1743
This pull request implements the following changes:
Introduces a configuration option to determine whether application metrics should be included.
Why are the changes needed?
Jira
There are too many application metrics when it reach the metrics capacity.
metrics_ActiveConnectionCount_Count{applicationId="1732528803184-dd11f77814d04bca2121140182ad7c0f",role="Worker"} 0 1732530713886 metrics_ActiveConnectionCount_Count{applicationId="1732529148502-3d72447b9773d89e941bcb83059424b7",role="Worker"} 0 1732530713886 metrics_ActiveConnectionCount_Count{applicationId="1732529499296-5facd993325e193ce54c8217066dfe26",role="Worker"} 0 1732530713886 metrics_ActiveConnectionCount_Count{applicationId="1732530155191-19068d5eba8a23b42a1e581b20ab0e5a",role="Worker"} 0 1732530713886 metrics_ActiveConnectionCount_Count{applicationId="1732527089786-9fc4a0bfe4c3cb49adf8a87919976a4f",role="Worker"} 0 1732530713886 metrics_ActiveConnectionCount_Count{applicationId="1732526536555-c8f0aaacf7dd92bd00a03bbe61c7216a",role="Worker"} 0 1732530713886 metrics_ActiveConnectionCount_Count{applicationId="1732527096128-5f416a4784a5d5b416dd4db471a51f44",role="Worker"} 0 1732530713886 metrics_ActiveConnectionCount_Count{applicationId="1732530177724-eeecda14217d8990ae0536eae83d3e3b",role="Worker"} 0 1732530713886 metrics_ActiveConnectionCount_Count{applicationId="1732527117022-769334f90b981c54280195da5d871351",role="Worker"} 0 1732530713886 metrics_ActiveConnectionCount_Count{applicationId="1732528325685-129d44a4392d98a830157333d9955558",role="Worker"} 0 1732530713886Does this PR introduce any user-facing change?
No
How was this patch tested?
UT