GH-44910: [Swift] Fix IPC stream reader and writer impl #45029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
changed the title
kou
reviewed
Dec 15, 2024
| @@ -216,7 +216,67 @@ public class ArrowReader { // swiftlint:disable:this type_body_length | |||
| return .success(RecordBatch(arrowSchema, columns: columns)) | |||
| } | |||
|
|
|||
| public func fromStream( // swiftlint:disable:this function_body_length | |||
| public func fromMemoryStream( // swiftlint:disable:this function_body_length | |||
There was a problem hiding this comment.
Could you add a comment that explains the difference between fromMemoryStream and fromFileStream?
| var schemaMessage: org_apache_arrow_flatbuf_Schema? | ||
| while length != 0 { | ||
| if length == CONTINUATIONMARKER { | ||
| offset += Int(MemoryLayout<Int32>.size) |
There was a problem hiding this comment.
Is this the size of length data?
How about using UInt32 not Int32 because length data is UInt32 not Int32?
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes IPC incorrect stream format issue.
Changes have been tested with:
This PR includes breaking changes to public APIs.
Writer and reader APIs have changed:
Reader:
fromStream -> fromFileStream
Writer:
toStream -> toFileStream