Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE#3032 #3072

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

ISSUE#3032 #3072

wants to merge 2 commits into from

Conversation

JASH9898567
Copy link

@JASH9898567 JASH9898567 commented Dec 15, 2024

Made some changes such as-

  1. export const MY_CONSTANT = 'should obviously not be uppercased' . In place of THING_TO_BE_CHANGED, it created unnecessary confusion as export const is not going to change across different files.

  2. Another is an example of //good coding in README - export const MY_EXPORTED_FUNCTION = () => {
    return 'hello function';
    }; . As no example of this was already available in file.

Fixes #3032.

README.md Outdated
Comment on lines 3187 to 3189
export const MY_EXPORTED_FUNCTION = () => {
return 'hello function';
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the indentation on this is incorrect, and there's no reason for this to be an arrow function, so it shouldn't be:

Suggested change
export const MY_EXPORTED_FUNCTION = () => {
return 'hello function';
};
export function MY_EXPORTED_FUNCTION() {
return 'hello function';
};

but also this example has nothing to do with dangling commas, which is the section you've placed it in

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still doesn't make any sense in this section.

@ljharb ljharb marked this pull request as draft December 16, 2024 00:03
Co-authored-by: Jordan Harband <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect constant export example
2 participants