Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing an error in getManifestFromRepo when the github API rate limiting response is a JSON object. #945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Throwing an error in getManifestFromRepo when the github API rate limiting response is a JSON object. #945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10063,7 +10063,11 @@ function getManifestFromRepo(owner, repo, auth, branch = 'master') {
core.debug('Invalid json');
}
}
return releases;
if (!releases.hasOwnProperty('documentation_url')){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dist/index.js is not where these changes should be directly made.

This index.js is a form of webpack and gets auto-generated from the source files in the src directory.

setup-python/package.json

Line 13 in 70dcb22

"release": "ncc build -o dist/setup src/setup-python.ts && ncc build -o dist/cache-save src/cache-save.ts && git add -f dist/",

Fundamentially you're trying to update the getManifestFromRepo function. That can be found here:

setup-python/src/install-python.ts

Lines 47 to 57 in 70dcb22

export function getManifestFromRepo(): Promise<tc.IToolRelease[]> {
core.debug(
`Getting manifest from ${MANIFEST_REPO_OWNER}/${MANIFEST_REPO_NAME}@${MANIFEST_REPO_BRANCH}`
);
return tc.getManifestFromRepo(
MANIFEST_REPO_OWNER,
MANIFEST_REPO_NAME,
AUTH,
MANIFEST_REPO_BRANCH
);
}

That uses a function from the our tool-cache NPM package in the actions/toolkit repository. This is the actual place where the change would need to be made: https://github.com/actions/toolkit/blob/6dd369c0e648ed58d0ead326cf2426906ea86401/packages/tool-cache/src/tool-cache.ts#L589-L632

So upstream the change would need to be made to tool-cache, a new version would then need to be published and then pulled into this repository/action. https://www.npmjs.com/package/@actions/tool-cache

I recommend submitting a PR to https://github.com/actions/toolkit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the feedback on this issue. I'll investigate your recommendation.

return releases;
}else{
throw new Error ('github API rate limiting response in JSON format')
}
});
}
exports.getManifestFromRepo = getManifestFromRepo;
Expand Down