Handle dynamic imports with no file extension #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for all .js files in an import destination, adds a copy with no file extension to the import map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every
.jsfile in the import destination directory, this code adds a copy of the key that omits the file extension, and which will point to the same module in the final product. Note that to use the plugin for import statements without file extensions at all, thetransformExtensionsoption needs to include an empty string.Addresses #7.
Maybe it should be considered to add an option that enables this behavior. If the behavior should apply to file extensions other than
.js, the option could include a list of file extensions that may be omitted, similar totransformExtensions.