Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magikh42 steam app news use app name #3977

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Magikh42
Copy link

Bridge: Steam App News

Hello, I added a checkbox to allow using the app name instead of author name, I think it's more practical for filtering by game in the user's preffered reader

I might have swapped commit messages and description but I don't know how to change that, sorry
If someone can set the messages to what I put in the description it would be nice, thank you

Copy link

github-actions bot commented Feb 12, 2024

Pull request artifacts

Bridge Context Status
SteamAppNews 1 untitled (current) ✔️
SteamAppNews 1 untitled (pr) ⚠️ (shutdown) 8192: Creation of dynamic property SteamAppNewsBridge::$app_name is deprecated in bridges/SteamAppNewsBridge.php line 59

last change: Tuesday 2024-03-19 10:50:28

@Magikh42 Magikh42 force-pushed the Magikh42-SteamAppNews-useAppName branch from 5ce3b65 to 2b45796 Compare February 12, 2024 13:31
@dvikan
Copy link
Contributor

dvikan commented Feb 12, 2024

this will break existing feed urls because the tags parameter is gone.

@Magikh42
Copy link
Author

this will break existing feed urls because the tags parameter is gone.

Can you explain how it would break anything I don't understand
The use_app_name is optional so previous feeds would still works using author name but new feeds could be generated using app name in place of author name

@dvikan
Copy link
Contributor

dvikan commented Feb 14, 2024

rss-bridge disallows url parameters who are not defined in the bridge.

(i consider this a bug but havent found time to fix it yet.)

so when tags is gone, it will fail on all existing feed urls.

@dvikan
Copy link
Contributor

dvikan commented Mar 31, 2024

@otakuf pls help

@otakuf
Copy link
Contributor

otakuf commented May 19, 2024

@otakuf pls help

what help, sry i don`t get it. Magikh42 want to add some functionality.

@dvikan
Copy link
Contributor

dvikan commented Jun 18, 2024

@Magikh42

there are feeds out there using this bridge. they might be using the tags parameter in those urls.

if tags parameter is removed, these feeds will break. do you understand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants