Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LLVM to 18.1.8 #16032

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Bump LLVM to 18.1.8 #16032

wants to merge 7 commits into from

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Sep 2, 2024

No description provided.

@Megamouse Megamouse added CPU Build and CI Anything related to the build process and continuous integration labels Sep 2, 2024
@kd-11 kd-11 marked this pull request as ready for review September 10, 2024 06:48
@kd-11 kd-11 marked this pull request as draft September 10, 2024 09:59
@kd-11 kd-11 closed this Sep 12, 2024
@kd-11 kd-11 reopened this Sep 12, 2024
@kd-11 kd-11 marked this pull request as ready for review September 12, 2024 09:15
@Megamouse
Copy link
Contributor

  • See 16.0.1 in BUILDING.md
  • See 16.0.1 in get_keys_windows.sh

@kd-11 kd-11 closed this Oct 5, 2024
@kd-11 kd-11 reopened this Oct 5, 2024
@Megamouse
Copy link
Contributor

Needs conflict solved

@kd-11
Copy link
Contributor Author

kd-11 commented Nov 22, 2024

It needs a lot done actually. I'll try and fix it before end of year.

@digant73
Copy link
Contributor

digant73 commented Dec 13, 2024

Downloaded from the llvm official repo both the source and pre-compiled llvm 18.1.8 version.
In 3rdparty/llvm/CMakeLists.txt, the following changes need to be applied:

find_package(LLVM 16.0 CONFIG)

in

find_package(LLVM 18.1 CONFIG)

and

if (LLVM_VERSION VERSION_LESS 16)
    message(FATAL_ERROR "Found LLVM version ${LLVM_VERSION}. Required version 16 or above. \
        Enable BUILD_LLVM option to build LLVM from included as a git submodule.")

in

if (LLVM_VERSION VERSION_LESS 18.1)
    message(FATAL_ERROR "Found LLVM version ${LLVM_VERSION}. Required version 18.1 or above. \
        Enable BUILD_LLVM option to build LLVM from included as a git submodule.")

I could test it under Windows 11:

  • with CMake: with the above changes, I was able to successfully compile and build the application.
  • with Visual Studio: I was able to compile llvm with MSVC compiler while it failed with clang (some errors on some included Qt .h files). However the llvm libs (both the successfully compiled and the pre-compiled versions) failed on linking to rpcs3 (llvm seems to be compiled as /MD while rpcs3 was compiled as /MT)

@kd-11
Copy link
Contributor Author

kd-11 commented Dec 13, 2024

In this case I know why it didn't build, I need to update some preset files. I just ran out of time, hopefully I'll get this done during the holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration CPU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants