Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdin: Fix flake version_info check #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arkivm
Copy link

@arkivm arkivm commented Nov 25, 2021

Fix version check when built with newer versions of flake8 (currently at v4.0.1).

@arkivm arkivm force-pushed the fix-flake-version-check branch from c531c24 to 649ee70 Compare November 25, 2021 08:47
@sigmavirus24
Copy link
Member

polyfill really shouldn't be necessary for code-bases only supporting v3 and v4. It was primarily targetted at v2 and v3

@arkivm
Copy link
Author

arkivm commented Nov 25, 2021

@sigmavirus24 thanks for the info. We have another package pep8-naming that depends on flake8-polyfill. So, we should address this breakage in the nixpkgs repo. Also, I see flake>=3.9.1 here. Is the flake8_polyfill>=1.0.2,<2 necessary if we don't need flake8-polyfill for flake versions > 3.x?

@sigmavirus24
Copy link
Member

It isn't necessary, no. An issue needs to be raised against that repository though.

mbakke pushed a commit to guix-mirror/guix that referenced this pull request Jun 7, 2022
This package is mostly useful for Flake8 version 2 or 3 (see:
PyCQA/flake8-polyfill#14 (comment)).

* gnu/packages/python-xyz.scm (python-flake8-polyfill): Delete variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants