fix capture to file #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmavirus24
approved these changes
Apr 14, 2024
asottile
reviewed
Apr 14, 2024
sigmavirus24
requested changes
Apr 14, 2024
|
My apologies, I was not familiar with pre-commit. TIL. |
asottile
force-pushed
the
fix-json-output-to-file
branch
from
1978bc4 to
081bb17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
combination of --format and --output results in an empty output file
Example:
flake8 --format json --output $(tty)
flake8 --format json-pretty --output $(tty)
Pre-fix:
output truncated in file
Post-fix:
expected output in file
Subclasses of base.BaseFormatter.close need to call super().close() in order to close the output file handle and flush buffered data to the output file otherwise it is lost when flake8 exist.