Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add anchors for rules and config options #491

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 5, 2024

This will allow us to link to them directly.
@@ -58,76 +58,110 @@ If you'd like to do a PR we have development instructions `here <https://github.
List of warnings
----------------

.. _B001:

**B001**: Do not use bare ``except:``, it also catches unexpected events
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to add a link to name so that users can obtain it without having to dig through the source code.

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. This would be useful, I can see.

Is there any way we can make rstcheck happy here?

Can we look at adding the correct --ignore-directives to the pre-commit config please to not error rstcheck since this is a known problem.

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge and fix the linting locally

@cooperlees cooperlees merged commit 7ee1976 into PyCQA:main Dec 12, 2024
6 of 7 checks passed
@jtojnar jtojnar deleted the readme-anchors branch December 12, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants