Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove lxml from blacklist #1212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove lxml from blacklist #1212

wants to merge 1 commit into from

Conversation

djbrown
Copy link

@djbrown djbrown commented Dec 19, 2024

removes B320 (xml_bad_etree) and B410 (import_lxml)

fixes #767

@djbrown djbrown marked this pull request as ready for review December 19, 2024 02:45
@djbrown djbrown mentioned this pull request Dec 19, 2024
Open
sigmavirus24
sigmavirus24 reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion:

  • We should do this
  • We should add very clear notes to our changelog
  • We should start pointing people away from defused XML as it's maintenance status means lxml is likely to be safer going forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 left review comments

@ericwb ericwb Awaiting requested review from ericwb ericwb is a code owner

@lukehinds lukehinds Awaiting requested review from lukehinds lukehinds is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lxml guidance is not useful
2 participants
@djbrown @sigmavirus24