Now testing events in constructors! #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
added
feature
frangio
reviewed
Nov 22, 2018
|
@frangio PTAL! |
This was referenced Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to contain the changes in separate commits so that they can more easily be reviewed in order.
In the process, I got rid of
decodeLogs, since it is too low level, and was only used once (in a quite awful way). That meant improving and changing whatinTransactiondoes: it receives a transaction hash and a contract object, and looks for events emitted by a contract of that type in that transaction. This is necessary when events were not emitted by the called contract but by an indirectly called one, since truffle won't decode those (see the newinLogstests).A bit more work is missing to support multiple events of the same type being emitted in a single transaction (what
PaymentSplitterdoes at construction), but that should be easy to include after this is merged.Fixes #1354