Added a logic to omit : when the port number is not present.
#1377
+24
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravkeshre
requested review from
adashen,
SLdragon and
formulahendry
as code owners
|
This issue pop up in our production app, all of teams toolkit samples with configureable tabs have this piece of code and because of the ":" causes our app not to work in IOS. the ":port" should only be added when there is port and if there is no port it ends up as ":" |
… same change in other files as well.
gauravkeshre
requested review from
MSFT-yiz,
HuihuiWu-Microsoft,
tecton,
kimizhu,
swatDong,
kuojianlu,
KennethBWSong,
eriolchan,
hund030,
Yimin-Jin,
dooriya and
qinezh
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teams regex does not support urls with domain ending with colon without a port number.
Eg:
https://www.microsoft.com:/some_pathThis PR adds a logic to omit
:when the port number is not present.A lot of developers will adopt these examples and will find the samples not working on Teams Mobile.
It is important to note that this will only work when the port number is not present.