[Outlook] (Smart Alerts) Document dialog improvements #4935
Conversation
|
Learn Build status updates of commit 07d1e49: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
|
||
| > [!TIP] | ||
| > When you configure a button in the Smart Alerts dialog to open a task pane or run a function, a button for the implemented add-in command is also added to the ribbon or action bar of the Outlook client. Use the `contextData` option to distinguish when a user runs the add-in command from the Smart Alerts dialog. |
There was a problem hiding this comment.
This is actually only true for running a function. If the commandId provided by the developer is to open a taskpane, then they don't need an additional button displayed in the ribbon. This is not new to this feature; this required when invoking a function command from the Smart Alerts dialog.
| <span id="add-attachment" class="ms-Button-label">Add and send</span> | ||
| ``` | ||
|
|
||
| > [!TIP] |
There was a problem hiding this comment.
I'm not sure if this is the best place in the docs to do it, but we should document the fact that when calling sendAsync from a function command (not taskpane) the developer should only call event.completed() on the failure callback of the sendAsync API. This is because when the API is successful, the item is sent and the function command (UILess command) is killed by Outlook, since there is no way of guaranteeing the function app will continue to run after the item is sent. So no need for the developer to call event.completed on a successful callback of sendAsync.
We should also make it clear that developers should not write any code after sendAsync. This is because it is not guaranteed to run, since this API sends the item and kills the Add-in.
There was a problem hiding this comment.
I added the updated behavior and your suggestion to this article and in the sendAsync Remarks section.
|
Learn Build status updates of commit 0cec42d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| title: Handle OnMessageSend and OnAppointmentSend events in your Outlook add-in with Smart Alerts | |||
| description: Learn about the Smart Alerts implementation and how it handles the OnMessageSend and OnAppointmentSend events in your event-based Outlook add-in. | |||
| ms.date: 12/03/2024 | |||
| ms.date: 01/07/2024 | |||
There was a problem hiding this comment.
What's this date? Did you mean to change the year to 2025 too?
There was a problem hiding this comment.
Thanks for catching this! I thought I had fixed the year in the PRs, but it looks like I missed one. This date is just a placeholder. When we're ready to publish, I'll update it again.
| @@ -624,14 +693,16 @@ If you implemented the optional steps to customize the **Don't Send** button or | |||
|
|
|||
|  | |||
|
|
|||
| //TODO - Add screenshot with Take Action implementation. | |||
There was a problem hiding this comment.
did you intend to add this screenshot now or later?
There was a problem hiding this comment.
This will be added later before we publish.
| @@ -651,6 +722,8 @@ If you implemented the optional step to override the send mode option at runtime | |||
|
|
|||
|  | |||
|
|
|||
| //TODO - Update screenshot to include Don't Send option. | |||
|
Learn Build status updates of commit b6fdaf4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 27557a6: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Related PRs: