-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tasks/eval/nixpkgs: build the nixos manual / options to verify them #609
base: released
Are you sure you want to change the base?
Conversation
Just evaluating them isn't enough anymore, now that the docs are lazy.
There's a NixOS option that will allow us to go back to the old way and keep checking at eval-time: Now just need to set that somehow. |
maybe this but the drv still contains lazy-options.json
|
Is this really needed? The GitHub workflow already builds the NixOS manual whenever a file in |
Well, we have two options: 1) make this actually build the manual / don't be lazy when instantiating it; or 2) disable the functionality in ofborg, since we do have GHA setup for that. This is assuming the GHA workflow does indeed catch issues with the manual (I don't know). |
It does. I think we can go with 2, unless there's a need to do this in ofborg? GHA are a bit nicer, and they're already working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the discussion linked above (GHA doesn't run on backport PRs), I think it would be good to introduce this if it's feasible.
Just evaluating them isn't enough anymore, now that the docs are lazy.
Maybe we should keep the instantiate step but add the build step? idk