Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks/eval/nixpkgs: build the nixos manual / options to verify them #609

Draft
wants to merge 1 commit into
base: released
Choose a base branch
from

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Aug 12, 2022

Just evaluating them isn't enough anymore, now that the docs are lazy.


Maybe we should keep the instantiate step but add the build step? idk

Just evaluating them isn't enough anymore, now that the docs are lazy.
@cole-h
Copy link
Member Author

cole-h commented Aug 12, 2022

There's a NixOS option that will allow us to go back to the old way and keep checking at eval-time: documentation.nixos.options.splitBuild = false (thanks pennae!)

Now just need to set that somehow.

@Artturin
Copy link
Member

Artturin commented Dec 2, 2022

There's a NixOS option that will allow us to go back to the old way and keep checking at eval-time: documentation.nixos.options.splitBuild = false (thanks pennae!)

Now just need to set that somehow.

maybe this but the drv still contains lazy-options.json

nix-instantiate --arg configuration '{ ... }: { documentation.nixos.options.splitBuild = false; }' ./nixos/release.nix -A options

@ncfavier
Copy link
Member

ncfavier commented Jan 1, 2023

Is this really needed? The GitHub workflow already builds the NixOS manual whenever a file in nixos/ is modified.

@cole-h
Copy link
Member Author

cole-h commented Jan 3, 2023

Well, we have two options: 1) make this actually build the manual / don't be lazy when instantiating it; or 2) disable the functionality in ofborg, since we do have GHA setup for that. This is assuming the GHA workflow does indeed catch issues with the manual (I don't know).

@ncfavier
Copy link
Member

ncfavier commented Jan 3, 2023

This is assuming the GHA workflow does indeed catch issues with the manual

It does.

I think we can go with 2, unless there's a need to do this in ofborg? GHA are a bit nicer, and they're already working.

Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the discussion linked above (GHA doesn't run on backport PRs), I think it would be good to introduce this if it's feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants