-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LEMS-1733): adds aria labels to line segment #2032
Open
anakaren-rojas
wants to merge
10
commits into
main
Choose a base branch
from
LEMS-1733-add-aria-label-to-line-segment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (06114d8) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2032 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2032 |
Size Change: +728 B (+0.06%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
anakaren-rojas
changed the title
docs(changeset): adds aria labels to line segment
feat(LEMS01733): adds aria labels to line segment
Dec 18, 2024
anakaren-rojas
changed the title
feat(LEMS01733): adds aria labels to line segment
feat(LEMS-1733): adds aria labels to line segment
Dec 18, 2024
nishasy
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small requests.
packages/perseus/src/widgets/interactive-graphs/graphs/segment.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: LEMS-1733
Test plan:
Expected behavior
A line segment on a coordinate plane
Endpoint 1 at ${point1X} comma ${point1Y}. Endpoint 2 ${point2X} comma ${point2Y}. Segment length %(length)s
Endpoint ${endpointNumber} at ${x} comma ${y}
Screenshots: