Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI resources based on Robot-Framework #21

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Conversation

psaavedra
Copy link
Member

@psaavedra psaavedra commented Nov 18, 2024

  • Include Docker setup and scripts (Dockerfile, install-requirements.sh, podman-compose.sh, prepare-board.sh).
  • Add initial Robot Framework resources, tests, and test setup files.
  • Integrate scripts for touch events and video performance testing with Robot Framework.
  • Add conf/nginx.conf for NGINX configuration and docker-compose.yml for environment setup.
  • Provide a comprehensive README.md for project setup and usage instructions.

Also:

  • Add .gitattributes configuration for handling large files with Git LFS.
  • Include .github/scripts/ with various sanitizer scripts (run-all-sanatizers, sanatizer-pycodestyle, sanatizer-pyflake8, sanatizer-shellcheck) for automated code quality checks.
  • Add GitHub Actions workflow (sanatizers.yml) to run sanitizers on pull requests.
  • Add .gitignore with entries for backup files, virtual environments, and testing artifacts.

This is an example of use (video): https://people.igalia.com/psaavedra/videos/robot-meta-wpe-image.mp4)

@psaavedra psaavedra requested a review from clopez November 18, 2024 20:45
@psaavedra psaavedra self-assigned this Nov 18, 2024
Copy link

@clopez clopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool, looks quite clean and straight this robot-framework thing to write tests 👍

@@ -0,0 +1,30 @@
#! /bin/bash

set -e
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -eu

.ci/scripts/touch-one-finger-gesture.py Show resolved Hide resolved
Comment on lines +26 to +28
pushd "${BASEPATH}" || exit 1
scpi scripts
popd || exit 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in theory you don't need the || exit 1 if the script has set -eu

scarthgap uses a more recent recipe version.

Change-type: minor
Change-type: minor
- Added `python3-uinput_1.0.1.bb` recipe for the Python interface to
  the Linux uinput kernel module.
- Included a submitted patch to handle 64-bit `time_t` on 32-bit
  architectures to address Y2K38 issues in recent kernels and libcs.

Removed in b4efcecc63c86f3e7fa9d5c6205f1bd07d951fed for lack of
maintenance the situation change. There is a new release from 2024
March what addresses the build issues reported lately.

Signed-off-by: Pablo Saavedra <[email protected]>

Change-type: minor
The DIRFILES variable was removed as it is not required for the
package's functionality. Empty directories are no longer explicitly
handled in this recipe.
- Removed `wpe-2_42.conf` and added `wpe-2_46.conf`
- Updating version preferences:
  - `libwpe` updated to 1.16.%.
  - `wpewebkit` updated to 2.46.%.
- Removed obsolete patches:
  - `Add-LAYER_BASED_SVG_ENGINE-envvar_v2.42.patch`
  - `LBSE-Correct-animation-boundaries-avoiding-excessive.patch`
  - `Fix-LBSE-blurriness.patch`
- Added new patches for WPEWebKit 2.46:
  - `REGRESSION-263237-main-WPE-Identifiers-for-touch-poi.patch`
  - `Remove-Float16Array-from-WebInspectorUI.patch`
- Updated package configurations:
  - Added `experimental-wpe-platform`, `lbse`, and `offscreen-canvas`.
  - Removed `speech-synthesis`.
- Adjusted `FILES` for Web Inspector plugin in the WPEWebKit recipe.

Change-type: minor
* Added `WEBKIT_GST_DMABUF_SINK_ENABLED=1` to support DMABuf video sink.
* Included optional environment settings (commented for now):
  - Disabling WebKit sandbox: `WEBKIT_DISABLE_SANDBOX_THIS_IS_DANGEROUS`.
  - Custom GStreamer configurations for plugin ranking and debugging.
* Modified handling of maximized mode:
  - Dynamically calculates view width and height from Weston logs when
    `--maximized` is passed.
* Adjusted `cog-fdo` script:
  - Ensures additional parameters are passed correctly using array
    expansion.
  - Updated the invocation of `/usr/bin/cog` with sanitized arguments.
* Adjusted `cog-fdo-exported-wayland`:
  - Used `"$*"` with `su` to handle multiple arguments properly.
  - Replaced `$1` with `"$@"` for direct argument forwarding to
    `/usr/bin/cog-fdo`.

Change-type: minor
…ynamic-layer

- Introduced BBFILES_DYNAMIC entries in layer.conf to support dynamic layers
  for Raspberry Pi and Freescale platforms.
- Moved recipes and configurations to respective dynamic-layer directories:
  - Freescale-related kernel recipes and configs moved to `dynamic-layers/freescale-layer`.
  - Raspberry Pi kernel and bootfiles recipes relocated to `dynamic-layers/raspberrypi`.

Change-type: minor
- Deleted the following patches:
  - `0001-REGRESSION-263237-main-WPE-Identifiers-for-touch-poi.patch`
  - `0016-Remove-Float16Array-from-WebInspectorUI.patch`

Change-type: patch
- Moved PulseAudio-related packages to a new `PULSEAUDIO_INSTALL` variable.
- Updated PulseAudio installation for specific Raspberry Pi platforms:
  - Added `PULSEAUDIO_INSTALL` to `IMAGE_INSTALL` for `raspberrypi4`, `raspberrypi4-64`, and `raspberrypi5`.
  - raspberrypi3-mesa remains using ALSA to avoid PulseAudio issues in
    this device.
- Added `dbus` to the base `IMAGE_INSTALL` list for improved system compatibility.

Change-type: minor
…e support

- Added `RPI_KERNEL_DEVICETREE` to include a list of Raspberry Pi device tree binaries:
  - Covers models: Zero W, 2-B, 3-B, 3-B+, 4-B, and CM3.

Change-type: patch
- Replaced `IMAGE_FSTYPES:append` with a direct assignment to
  `IMAGE_FSTYPES` to include "wic.bmap wic.gz tar.gz".
- Ensures consistency and explicit definition of image formats for the
  build process.

Change-type: minor
@psaavedra psaavedra force-pushed the add_ci_tests branch 2 times, most recently from 17b67e4 to 6a17fc9 Compare December 18, 2024 07:54
Replace `$@` with `$*` to ensure that all command-line arguments are
passed correctly as a single word to the command. This change
prevents issues with argument handling when arguments contain spaces or
special characters.

Fixes SC2145 (error): Argument mixes string and array. Use * or
separate argument.
* Include Docker setup and scripts (`Dockerfile`, `install-requirements.sh`,
  `podman-compose.sh`, `prepare-board.sh`).
* Add initial Robot Framework resources, tests, and test setup files.
* Integrate scripts for touch events and video performance testing with Robot
  Framework.
* Add `conf/nginx.conf` for NGINX configuration and `docker-compose.yml` for
  environment setup.
* Provide a comprehensive `README.md` for project setup and usage instructions.

Also:

* Add `.gitattributes` configuration for handling large files with Git LFS.
* Include `.github/scripts/` with various sanitizer scripts
  (`run-all-sanatizers`, `sanatizer-pycodestyle`, `sanatizer-pyflake8`,
 `sanatizer-shellcheck`) for automated code quality checks.
* Add GitHub Actions workflow (`sanatizers.yml`) to run sanitizers on pull
  requests.
* Add `.gitignore` with entries for backup files, virtual environments, and
  testing artifacts.
The cog DRM script was updated to correctly handle arguments by wrapping
them with quotes ("$@"). This ensures proper handling of arguments
containing spaces or special characters.

Fixes SC2068 (error): Double quote array expansions to avoid
re-splitting elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants