Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wcstools 3.9.7 (new formula) #202219

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

wcstools 3.9.7 (new formula) #202219

wants to merge 2 commits into from

Conversation

cxwx
Copy link
Contributor

@cxwx cxwx commented Dec 23, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core macos-only Formula depends on macOS labels Dec 23, 2024
@daeho-ro daeho-ro changed the title wcstools 3.9.7 wcstools 3.9.7 (new formula) Dec 23, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 23, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 23, 2024
sha256 "525f6970eb818f822db75c1526b3122b1af078affa572dce303de37df5c7b088"
license "LGPL-2.0-only"

depends_on :macos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem accurate, since the homepage has references to using this on Linux.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but I don't have a linux machine now, maybe someone can help.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I close this pull or wait for someone help?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just remove this line and let this build on Linux CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as Makefile.osx only support for macos, need other file for built on linux, I've not test it on linux

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make all works on macOS (based on instructions in the Install file), this should work on Linux too. You can update the formula and it can be tested on Linux CI.

Formula/w/wcstools.rb Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. macos-only Formula depends on macOS new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants