pistache 0.4.26 (new formula) #202108

dgreatwood · 2024-12-22T03:20:54Z

Adding Pistache to homebrew-core for the first time.

Pistache is a modern, fast, elegant HTTP + REST C++17 framework with a pleasant API. It supports Linux (including via Debian - https://packages.debian.org/sid/libpistache-dev), macOS, Windows and BSD.

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

github-actions · 2024-12-22T03:26:42Z

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

dgreatwood · 2024-12-22T04:19:02Z

Looks like there is an error in linuxbrew case, missing libcurl dependency, I'll address and retest. Please standby for now. Thx.

Formula/p/pistache.rb

chenrui333 · 2024-12-22T04:29:21Z

Looks like there is an error in linuxbrew case, missing libcurl dependency, I'll address and retest. Please standby for now. Thx.

you can add uses_from_macos "curl"

Formula/p/pistache.rb

dgreatwood · 2024-12-23T19:51:07Z

Now passes homebrew CI on Linux and macOS. Made a number of updates as follows:

As suggested by @chenrui333, added libcurl as a dependency with "uses_from_macos"
As suggested by @chenrui333, removed SPDX copyright+license message
As suggested by @SMillerDev, removed redundant "--buildtype=release"
Updated formula to Pistache release 0.4.26 to support "--wrap-mode=nofallback" option in Linux (was already supported for macOS in Pistache 0.4.25)
Corrected formula to specify whether each dependency is/is not build only

Formula/p/pistache.rb

chenrui333 · 2024-12-23T20:31:21Z

thanks for the work, left couple of comments. 👍

dgreatwood · 2024-12-23T22:27:18Z

@chenrui333, thanks for your review. As you've seen, additional changes made per your comments:

Changed / removed formula-file comments as suggested
Made rapidjson and howard-hinnant-date into build-only dependencies
Added zlib as a Linux dependency with uses_from_macos

Formula/p/pistache.rb

Adding Pistache to homebrew-core for the first time. Pistache is a modern, fast, elegant HTTP and REST C++17 framework with a pleasant API. It supports Linux (including via Debian - https://packages.debian.org/sid/libpistache-dev), macOS, Windows and BSD. Also: Added libcurl and zlib as dependencies for Linux Pistache brew formula (come pre-installed in macOS). Removed SPDX copyright+license message from Pistache brew formula. Updated Pistache brew formula to Pistache release 0.4.26 to support "--wrap-mode=nofallback" option in Linux (was already supported for macOS). In the Pistache brew formula, correctly specify whether each dependency is/is not build only. Do not build Pistache's unit tests or examples.

carlocab

Thanks!

github-actions · 2024-12-25T04:24:26Z

@chenrui333 has requested bottles to be published to this PR.

chenrui333 · 2024-12-25T04:24:28Z

@dgreatwood, thanks for your first contribution to homebrew-core! Appreciate your efforts in here. 💯 ❤️

github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 22, 2024

chenrui333 reviewed Dec 22, 2024

View reviewed changes