-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Analytics updated configuration #561
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 65a7006 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c4fb5c7
to
d5f65fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just took a look and asked a question but can't approve since I'm not familiar with integrations configuration in this repo.
description: Look for this in your Google Analytics account. | ||
required: | ||
- tracking_id | ||
componentId: config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: why are we replacing the tracking id with a component id?
Could we add a title and description to it to clarify its role and use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look here for more context.
We're replacing the way we render the configuration. From controlled by declarative + controlled by gitbook-x to controlled by the integration completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This as well.
No description provided.