Fix workspace schemes doesn't match the result of xcodebuild -list -workspace
#869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongdonggaui
changed the title
xcodebuild -list -workspace #797xcodebuild -list -workspace
|
fix #797 |
Open
|
@dongdonggaui can you please add a test case? thank you! |
|
@dnkoutso got it，thanks for the reply |
|
ping @dongdonggaui if possible please add a test |
dnkoutso
reviewed
Jun 22, 2022
| @@ -82,6 +82,14 @@ def self.new_from_xcworkspace(path) | |||
| def self.from_s(xml, workspace_path = '') | |||
| document = REXML::Document.new(xml) | |||
| instance = new(document) | |||
| # Load projects reference in "Pods/" if needed | |||
| pods_path = "#{File.expand_path("..", workspace_path)}/Pods" | |||
There was a problem hiding this comment.
I think this project doesnt know about "Pods". This fix might be better in CocoaPods gem instead.
|
sudo gem install cocoapods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.