MVC to fix path issues on Windows #771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canop
reviewed
Oct 26, 2023
| @@ -409,5 +409,10 @@ mod execution_builder_test { | |||
| } | |||
|
|
|||
| fn path_to_string<P: AsRef<Path>>(path: P) -> String { | |||
| path.as_ref().to_string_lossy().to_string() | |||
| let is_bash_on_windows = true; | |||
There was a problem hiding this comment.
Yes, deliberately so! I have hardcoded it locally to allow me to test broot in Windows bash, and when I've done some testing I'll implement the best method.
This is more of a CTA for any similar bugs that I can fix in one shot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a Windows user who mainly uses bash. I can see there are some rough edges on Windows, and it's noted elsewhere that the maintainers aren't Windows users themselves (which is understandable). I'm hoping to try and work through some of the rough edges to do with path handling, especially with bash.
I can see #588, #460, #78, #98, #99 which should mostly be fixed by something similar to the below. Have you got any others?
I'll have to do some work to formally detect cygwin / bash on windows, but I'll hardcode it locally for myself and run it for a while to see how it goes.
I wonder if the more elegant solution is to use / for paths everywhere instead of quoting, but that will bring up its own issues. I'll see how it works with the quoting for a while and then think about it a bit more.