Support for react-redux connect (fixes #51)

ArnaudBarre · Oct 19, 2024 · cb7cecd · cb7cecd
1 parent 762c15c
commit cb7cecd
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- Support for `react-redux` connect (`export default connect(mapStateToProps, mapDispatchToProps)(MyComponent)`) (fixes #51)
+
 ## 0.4.12
 
 - Support type assertion on default export (fixes #48)

diff --git a/bun.lockb b/bun.lockb
diff --git a/src/only-export-components.test.ts b/src/only-export-components.test.ts
@@ -179,6 +179,10 @@ const valid = [
     name: "Export as default",
     code: "export { App as default }; const App = () => <>Test</>;",
   },
+  {
+    name: "Allow connect from react-redux",
+    code: "const MyComponent = () => {}; export default connect(() => ({}))(MyComponent);",
+  },
 ];
 
 const invalid = [

diff --git a/src/only-export-components.ts b/src/only-export-components.ts
@@ -157,8 +157,16 @@ export const onlyExportComponents: TSESLint.RuleModule<
               handleExportIdentifier(node.id, true);
             }
           } else if (node.type === "CallExpression") {
-            // we rule out non HoC first
-            if (node.callee.type !== "Identifier") {
+            if (
+              node.callee.type === "CallExpression" &&
+              node.callee.callee.type === "Identifier" &&
+              node.callee.callee.name === "connect"
+            ) {
+              // support for react-redux
+              // export default connect(mapStateToProps, mapDispatchToProps)(Comp)
+              mayHaveReactExport = true;
+            } else if (node.callee.type !== "Identifier") {
+              // we rule out non HoC first
               // export default React.memo(function Foo() {})
               // export default Preact.memo(function Foo() {})
               if (

diff --git a/yarn.lock b/yarn.lock
@@ -458,7 +458,7 @@ builtin-modules@^3.3.0:
   resolved "https://registry.npmjs.org/builtin-modules/-/builtin-modules-3.3.0.tgz"
   integrity sha512-zhaCDicdLuWN5UbN5IMnFqNMhNfo919sH85y2/ea+5Yg9TsTkeZxpL+JLbp6cgYFS4sRLp3YV4S6yDuqVWHYOw==
 
-bun-types@^1.0.15:
+bun-types@^1.1.27:
   version "1.1.27"
   resolved "https://registry.npmjs.org/bun-types/-/bun-types-1.1.27.tgz"
   integrity sha512-rHXAiIDefeMS/fleNM1rRDYqolJGNRdch3+AuCRwcZWaqTa1vjGBNsahH/HVV7Y82frllYhJomCVSEiHzLzkgg==