Modernize the project

[LiorBanai]

• last pull is broken
• no update for the last 7 months.
• no update of dependency vulnerabilities
• very old net framework targets (like net45)
• yml target out of support frameworks

[somdoron]

you are welcome to contribute and solve those issues. I would help you release a new version to nuget.

[LiorBanai]

sure, will do.

[LiorBanai]

@somdoron I'm updating other old stuff like

• remove net3.1 and net 6 in github pipeline
• update github actions

I'll push new pr later on.

[somdoron]

Thanks. We used to have a CI which doesn't seem to work anymore. We used appveyor, we might want to move to github actions.

…

On Thu, 19 Dec 2024, 19:23 Lior Banai, ***@***.***> wrote: @somdoron <https://github.com/somdoron> I'm updating other old stuff like - remove net3.1 and net 6 in gituhb pipeline - update github actions I'll push new pr later on. — Reply to this email directly, view it on GitHub <#1109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUW75U445U6MLIURMWAOOT2GL6H3AVCNFSM6AAAAABT4M63ZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJVGI2DCNJYGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[LiorBanai]

the ci is different on my own fork:
in this repo it fails: #1111
on my fork it passes: LiorBanai#1

[LiorBanai]

@somdoron I see the pr is merged and passed. Thanks.
Anything I can do to help with pushing new version to nuget.org?

[somdoron]

Can you create a new CI workflow to push a nuget version on tag or release? I will add the nuget key to the project variables.

…

On Thu, 19 Dec 2024, 20:05 Lior Banai, ***@***.***> wrote: @somdoron <https://github.com/somdoron> I see the pr is merged and passed. Thanks. Anything I can do to help with pushing new version to nuget.org? — Reply to this email directly, view it on GitHub <#1109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUW75VHRXD32JLJFGMLPW32GMDGFAVCNFSM6AAAAABT4M63ZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJVGQ3DKOBYGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tmatthey]

@LiorBanai Thanks for the push! I've also an outstanding PR 1093 Since there was nothing happened I forked with my PR.

[LiorBanai]

in my nugets workflow i just push the nuget always (when on master/main) with the skip duplicates flags. This allows the flexibility to update the version in the csproj/build.prop without needing a tag.
@somdoron do yuo want a push only on tag or using the same approch?

[LiorBanai]

@tmatthey is that still relevant? maybe worth adding it before releasing new version..

[somdoron]

We can push pre release on every commit and a final version on release/tag

[tmatthey]

@tmatthey is that still relevant? maybe worth adding it before releasing new version..

Yes, that would be very preferable. After we used to changes from PR 1093 we have not seen any exceptions.

[LiorBanai]

Not sure why there is an issue:
looking in the release.yml and prerelease.yml files, all the infrastructure is already there to push nugets so it should already work no?.

[tmatthey]

Just one tiny comment on target frameworks; standard 2.0 is the last common target which both .Net Framework and .net can consume. Unfortunately, NetMQ has many dependencies where the standard 2.0 has vulnerabilities, which won't be fixed, I guess.

[tmatthey]

And shouldn't the version be bumped up, minor? major? I would suggest major since some targets have be removed, breaking change.