Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpt-pr-bot exceeding GitHub API limit #144

Open
stephenmcgruer opened this issue Feb 12, 2020 · 0 comments
Open

wpt-pr-bot exceeding GitHub API limit #144

stephenmcgruer opened this issue Feb 12, 2020 · 0 comments
Assignees

Comments

@stephenmcgruer
Copy link
Contributor

See web-platform-tests/wpt.live#26, where this impacted a different service performed by wpt-pr-bot.

Currently we seem to be cresting right at the edge of the API limit (5000 requests an hour), such that if the timing of the WebKit sync code happens once more in an hour then we will go over. This occurs rarely, but is still something we should be very cautious of.

2020-02-11T12:03:43.060727Z GET https://api.github.com/repos/web-platform-tests/wpt/issues/15431 
2020-02-11T12:03:43.107724Z Error: API rate limit exceeded for user ID 16780864.
    at errFrom (/srv/lib/github.js:10:15)
    at Request.onResponse [as _callback] (/srv/lib/github.js:87:29)
    at Request.self.callback (/srv/node_modules/request/request.js:185:22)
    at Request.emit (events.js:210:5)
    at Request.<anonymous> (/srv/node_modules/request/request.js:1161:10)
    at Request.emit (events.js:210:5)
    at IncomingMessage.<anonymous> (/srv/node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:299:28)
    at IncomingMessage.emit (events.js:215:7)
    at endReadableNT (_stream_readable.js:1183:12) { 
2020-02-11T12:03:43.107745Z   statusCode: 403 
2020-02-11T12:03:43.107755Z } 

As an quick fix for web-platform-tests/wpt.live#26, I plan to drop the WebKit sync schedule to once every 15 minutes (current once every 5), which should be the bulk of API requests. Then we need to look at the code, and see if we can reduce how often we call GitHub APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant