Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No information is available needs IDs and a review #538

Open
GeorgeKerscher opened this issue Dec 13, 2024 · 1 comment
Open

No information is available needs IDs and a review #538

GeorgeKerscher opened this issue Dec 13, 2024 · 1 comment

Comments

@GeorgeKerscher
Copy link
Collaborator

In Pr 535, I mention that the last statement in examples is "No information is available" and this needs to be reviewed. I wanted to capture this issue instead of having get lost when that PR is merged.

In many places there was a variable and a ID string that matched well. However, in other places the logic in the techniques do not lead to that statement; I would call this a fall through statement, i.e., the condition where everything fails because there is no metadata present.

There are also the markup of the ID that should be placed in the guidelines.

I think the guidelines should be updated after the techniques are revised.

@mattgarrish
Copy link
Member

The recent removal of the headings makes these fall-through statements confusing. There's now nothing in the techniques about how to add headings, presumably forcing implementers to read the json file to figure out what to do, although even that is not made clear.

But if the headings are now at the discretion of implementers, it means you could get multiple "no information available" statements with no context. It's also not clear how the statements would be modified depending on whether the implementer uses the predefined headings from the guidelines or whether they come up with some new heading group of their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants