Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Wrong generating ids customBlocks #333

Open
Mertico opened this issue Mar 18, 2020 · 2 comments · May be fixed by #371
Open

Wrong generating ids customBlocks #333

Mertico opened this issue Mar 18, 2020 · 2 comments · May be fixed by #371
Milestone
Zero Issues

Comments

@Mertico
Copy link

Mertico commented Mar 18, 2020

Version

5.0.0

Reproduction link

https://github.com/intlify/rollup-plugin-vue-i18n

Steps to reproduce

Clone https://github.com/intlify/rollup-plugin-vue-i18n install and update rollup-plugin-vue to 5.1.6

VuePlugin({
        customBlocks: ['i18n'],
      })

Generatered
tag <i18n lang="json"></i18n>

?rollup-plugin-vue=customBlocks.0.json

tag <i18n></i18n>

?rollup-plugin-vue=customBlocks.0.i18n

and add default lang

VuePlugin({
        customBlocks: ['i18n'],
        defaultLang: {
          i18n: 'json'
        }
      })

tag <i18n></i18n>
?rollup-plugin-vue=customBlocks.0.json

What is expected?

maybe generated ids ?rollup-plugin-vue=customBlocks.<tagName>.<lang?>

What is actually happening?

Generate wrong ids
@caxerx
Copy link

caxerx commented Jul 13, 2020

any update on this issue?

@caxerx caxerx linked a pull request Jul 13, 2020 that will close this issue
Open
@znck znck added this to the Zero Issues milestone Oct 22, 2020
@spacedawwwg
Copy link

spacedawwwg commented Dec 7, 2020 •
edited
Loading

I've just found this issue as I'm come across the same problem.

My custom block has multiple attributes (src, lang, target)

Is there a solution to use attributes on customBlocks @znck ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Zero Issues
Development

Successfully merging a pull request may close this issue.

feat: keep custom block type when block has lang caxerx/rollup-plugin-vue
4 participants
@Mertico @spacedawwwg @znck @caxerx