Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix minify when builder.sharedPlugins: true #19025

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix minify when builder.sharedPlugins: true #19025

wants to merge 1 commit into from
+73 −2

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa marked this pull request as ready for review December 20, 2024 09:18
sapphi-red
sapphi-red reviewed Dec 24, 2024
View reviewed changes
packages/vite/src/node/plugins/esbuild.ts
Comment on lines +329 to +332
const config = this.environment.config
if (config.esbuild === false) {
return
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using applyToEnvironment hook?

@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) feat: build labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feat: build p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot specify minify independently for environments when builder.sharedPlugins: true
2 participants
@hi-ogawa @sapphi-red