[testing-library/jasmine-dom] Add default export #71300
Conversation
|
@sebastian-altamirano Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71300,
"author": "sebastian-altamirano",
"headCommitOid": "8476dfdfaab989a6fc3304133c834f5ed06bc8dc",
"mergeBaseOid": "c39e00d70995131a814a23b8054ea191d910925b",
"lastPushDate": "2024-11-30T21:42:06.000Z",
"lastActivityDate": "2024-12-01T22:08:26.000Z",
"mergeOfferDate": "2024-12-01T18:59:58.000Z",
"mergeRequestDate": "2024-12-01T22:08:26.000Z",
"mergeRequestUser": "sebastian-altamirano",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "testing-library__jasmine-dom",
"kind": "edit",
"files": [
{
"path": "types/testing-library__jasmine-dom/index.d.ts",
"kind": "definition"
},
{
"path": "types/testing-library__jasmine-dom/test/testing-library__jasmine-dom-global-tests.ts",
"kind": "test"
}
],
"owners": [
"brrianalexis"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "brrianalexis",
"date": "2024-12-01T18:59:21.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2509393831,
"ciResult": "pass"
} |
typescript-bot
added
the
Popular package
|
🔔 @brrianalexis — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
Owner Approved
|
@sebastian-altamirano: Everything looks good here. I am ready to merge this PR (at 8476dfd) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@brrianalexis: you can do this too.) |
|
Ready to merge |
Currently, the type definitions extend the matchers exposed by Jasmine but do not provide a definition for the default export, without this definition TS does not know that the package can be imported, causing the error reported at testing-library/jasmine-dom#40.
Fixes testing-library/jasmine-dom#40
pnpm test <package to test>.If changing an existing definition:
package.json.