Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata.nullable is inconsistent (E.g. customer vs subscription) #67

Open
broccolihighkicks opened this issue Jan 10, 2021 · 1 comment
Labels

Comments

@broccolihighkicks
Copy link

Both the Customer and Subscription schema have a metadata property:

  "metadata": {
      "additionalProperties": {
          "maxLength": 500,
          "type": "string"
      },
      "description": "...",
      "type": "object"
  },

But the Subscription lists metadata in the required fields list:

        "required": [

            "metadata",
        ],

Does this imply that the metadata field is nullable for the customer object, but not for the subscription object?

Why is metadata required on the subscription but not the customer?

The docs both show this for both objects (no required tag):

image

@remi-stripe
Copy link
Collaborator

@broccolihighkicks It's mostly an inconsistency on our end whether we return metadata: null, metadata: {} or no metadata key at all in the response. It shouldn't have much impact beyond that but it's something we'd like to fix in the future so I'm going to tag this as future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants